[opt](coord) use single instance only with small limit#33888
Merged
yiguolei merged 2 commits intoapache:masterfrom Apr 19, 2024
Merged
[opt](coord) use single instance only with small limit#33888yiguolei merged 2 commits intoapache:masterfrom
yiguolei merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 38386 ms |
TPC-DS: Total hot run time: 184048 ms |
ClickBench: Total hot run time: 29.97 s |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 19, 2024
TPC-H: Total hot run time: 38498 ms |
TPC-DS: Total hot run time: 184285 ms |
ClickBench: Total hot run time: 30.07 s |
xiaokang
pushed a commit
that referenced
this pull request
Apr 19, 2024
yiguolei
approved these changes
Apr 19, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Gabriel39
approved these changes
Apr 19, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 19, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
yiguolei
pushed a commit
that referenced
this pull request
Sep 4, 2024
… limit involved (#39927) For queries like `select * from tbl limit 100;`, we should limit the parallelism to 1. We already have strategies in our code, but we can not control its behavior. So add session variables to control them. Previous pr like #33888 #36535 already has done something similar, this pr integrates them.
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Sep 4, 2024
… limit involved (apache#39927) For queries like `select * from tbl limit 100;`, we should limit the parallelism to 1. We already have strategies in our code, but we can not control its behavior. So add session variables to control them. Previous pr like apache#33888 apache#36535 already has done something similar, this pr integrates them.
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Oct 18, 2024
… limit involved (apache#39927) For queries like `select * from tbl limit 100;`, we should limit the parallelism to 1. We already have strategies in our code, but we can not control its behavior. So add session variables to control them. Previous pr like apache#33888 apache#36535 already has done something similar, this pr integrates them.
yiguolei
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Oct 19, 2024
… limit involved (apache#39927) For queries like `select * from tbl limit 100;`, we should limit the parallelism to 1. We already have strategies in our code, but we can not control its behavior. So add session variables to control them. Previous pr like apache#33888 apache#36535 already has done something similar, this pr integrates them.
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Nov 8, 2024
… limit involved (apache#39927) For queries like `select * from tbl limit 100;`, we should limit the parallelism to 1. We already have strategies in our code, but we can not control its behavior. So add session variables to control them. Previous pr like apache#33888 apache#36535 already has done something similar, this pr integrates them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Followup #31342
When executing simple query like
select * from tbl limit 1.Doris will use only one instance for each scan node, to reduce the fan-out of simple queries.
But if the limit number is large, eg, 1 billion, this logic is not suitable.
So I add a new session variable
limit_rows_for_single_instance, default is 10000.Only if the limit number is lower than this value, Doris will use one instance for scan node.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...